Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Fingering Annotations and Markings. #403

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Conversation

manoskary
Copy link
Member

This pull request introduces several changes to enhance the handling of technical notations, specifically fingering, across various modules. The most important changes include adding support for technical notations in the export and import functions, and updating type annotations for better code clarity.

Score BASE module updates:

  • partitura/score.py: Added technical attribute to GenericNote class to support technical notations such as fingering.

Import functions updates:

  • partitura/io/importmatch.py: Added technical attribute handling in part_from_matchfile and introduced fingering_pattern for parsing fingering notations.
  • partitura/io/importmusicxml.py: Added functions get_technical_notations and parse_fingering to parse technical notations, and updated _handle_note to include technical attribute.

Export functions updates:

Type annotations and code improvements:

@manoskary manoskary added the enhancement New feature or request label Dec 3, 2024
@fosfrancesco fosfrancesco merged commit bb1adac into develop Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants