-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[!!!][TASK] Lock provider type in template artifact #95
Conversation
2abd1e2
to
f58f77a
Compare
Code Climate has analyzed commit 93581d5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.7% (0.0% change). View more on Code Climate. |
Codecov Report
@@ Coverage Diff @@
## 3.x #95 +/- ##
============================================
+ Coverage 98.20% 98.29% +0.09%
- Complexity 770 776 +6
============================================
Files 111 112 +1
Lines 2445 2462 +17
============================================
+ Hits 2401 2420 +19
+ Misses 44 42 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f58f77a
to
eee08f2
Compare
eee08f2
to
acd67a9
Compare
This seems ready for shipment. What could possibly be open here? |
d418e1e
to
93581d5
Compare
93581d5
to
86c025a
Compare
Wanna wait for codeclimate or fire at once? |
👏 |
Thanks for your approval. I'm too tired to wait for all those obviously unstable CGL tools. |
I feel you. |
Restoring a build artifact cannot be done properly if the original template provider cannot be determined. Hence, we now use the provider type instead of its name.
This is breaking change as it results in a new build artifact version (
1679497137
→1688738958
).