[new] Allow pattern matching in lambdas, and compile constructors #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alan Lawrence <[email protected]>
Closed
acl-cqc
reviewed
Aug 7, 2024
brat/Brat/Checker.hs
Outdated
| @@ -419,6 +487,73 @@ check' (Simple tm) ((), ((hungry, ty):unders)) = do | |||
| pure (((), ()), ((), unders)) | |||
| check' tm _ = error $ "check' " ++ show tm | |||
|
|
|||
|
|
|||
| -- Clauses from either function definitions or case statements (TODO), as we get | |||
There was a problem hiding this comment.
Think this TODO is bogus now? The TODO was this PR! :)
acl-cqc
reviewed
Aug 7, 2024
| qpred None = Nothing | ||
| qpred One = Just None | ||
| qpred Tons = Just Tons | ||
| data Quantity = None | One | Tons deriving (Enum, Show) |
There was a problem hiding this comment.
Some day we can move this, but let's not bother now
croyzor
changed the title
acl-cqc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow lambda expressions to have multiple clauses employing pattern matching logic just like what is done for top level definitions. This improves expressiveness as previously we couldn't pattern match in kernels that were defined as lambdas created by classical functions.
These multi-clause lambda expressions - "multilambdas" - are parsed inside curly braces, as many lambda expressions separated by a
|.Closes #8, #17