Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: give all next calls a label #61

Merged
merged 5 commits into from
Dec 3, 2024
Merged

feat: give all next calls a label #61

merged 5 commits into from
Dec 3, 2024

Conversation

croyzor
Copy link
Collaborator

@croyzor croyzor commented Dec 3, 2024

And other drive-by fixes pulled out from #59

@croyzor croyzor requested a review from acl-cqc December 3, 2024 09:43
Copy link
Collaborator

@acl-cqc acl-cqc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! A few suggestions but go ahead :)

brat/Brat/Checker/SolvePatterns.hs Outdated Show resolved Hide resolved
brat/Brat/Load.hs Outdated Show resolved Hide resolved
brat/Brat/Checker.hs Outdated Show resolved Hide resolved
@@ -724,7 +724,7 @@ checkBody fnName body cty = do
NoLhs tm -> pure (tm, (fcOf tm, fcOf tm))
Clauses (c :| cs) -> do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To give a bit more of a clue what's going on, consider

Suggested change
Clauses (c :| cs) -> do
Clauses (c@(abs,tm) :| cs) -> do
fc <- req AskFC
pure (WC fc (Lambda c cs), (fcOf abs, fcOf tm) c)

@croyzor croyzor merged commit 9bad538 into main Dec 3, 2024
2 checks passed
@croyzor croyzor deleted the holes-drive-bys branch December 3, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants