fix BadPortPull error message; refactor pullPorts not to require tuple #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight extra effort in two callsites (
id->fstis no effort really, so adding a. fstin one callsite) seems more than justified with the simplification in the third callsite (in SolvePatterns) and to the type signature of pullPorts.It's tempting at this point to drop the "port" nomenclature and just call it "pullToFront" (and parametrize by the "port" type), but given we are using errors called BadPortPull and AmbiguousPortPull, let's keep the naming consistent with those. However, fix the BadPortPull error/message, slightly bodged up in #62