Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: Add very basic debug info #336

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

hack: Add very basic debug info #336

wants to merge 1 commit into from

Conversation

mark-koch
Copy link
Collaborator

@mark-koch mark-koch commented Jul 26, 2024

This branch is for testing of lowering of DWARF info in hugr-llvm. This implementation is quite hacky; we should wait until #257 is done to properly implement this.

This branch adds debug info to the following nodes:

  • Module (requires passing an explict file parameter when constructing a GuppyModule)
  • FuncDefn
  • Most ExtensionOps

@hugrbot
Copy link
Collaborator

hugrbot commented Jul 26, 2024

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification
and it looks like your proposed title needs to be adjusted.

Your title should look like this. The scope field is optional.

<type>(<scope>): <description>

If the PR includes a breaking change, mark it with an exclamation mark:

<type>!: <description>

and include a "BREAKING CHANGE:" footer in the body of the pull request.

Details:

Unknown release type "hack" found in pull request title "hack: Add very basic debug info". 

Available types:
 - feat
 - fix
 - docs
 - style
 - refactor
 - perf
 - test
 - ci
 - chore
 - revert

@@ -346,7 +351,7 @@ def add_node(
parent=parent,
in_port_types=[p.ty for p in inputs] if inputs is not None else input_types,
out_port_types=output_types,
meta_data=meta_data or {},
meta_data=(meta_data or {}) | debug_metadata(debug),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this a dictionary update? nice

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.59%. Comparing base (6698b75) to head (a023228).
Report is 5 commits behind head on main.

Files Patch % Lines
guppylang/hugr_builder/hugr.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #336      +/-   ##
==========================================
- Coverage   92.67%   92.59%   -0.08%     
==========================================
  Files          45       45              
  Lines        5105     5148      +43     
==========================================
+ Hits         4731     4767      +36     
- Misses        374      381       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants