Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update devenv #134

Merged
merged 1 commit into from
Oct 21, 2024
Merged

chore: update devenv #134

merged 1 commit into from
Oct 21, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented Oct 21, 2024

Note that updating rustc caused several errors, which are fixed here. New clippy suggestions are also applied.

@doug-q doug-q requested a review from a team as a code owner October 21, 2024 08:00
@doug-q doug-q requested a review from aborgna-q October 21, 2024 08:00
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.13%. Comparing base (f7c86d5) to head (25740cb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
+ Coverage   85.12%   85.13%   +0.01%     
==========================================
  Files          31       31              
  Lines        4235     4238       +3     
  Branches     4235     4238       +3     
==========================================
+ Hits         3605     3608       +3     
  Misses        305      305              
  Partials      325      325              
Flag Coverage Δ
rust 85.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devenv looks like working fine for me, the test relating to #103 fails for me but I see that is being addressed in #131

Edit: can confirm all tests pass with both changes.

@doug-q doug-q added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit ce14684 Oct 21, 2024
10 checks passed
@doug-q doug-q deleted the doug/fix-beta-tests branch October 21, 2024 09:07
@aborgna-q
Copy link
Collaborator

aborgna-q commented Oct 21, 2024

I made a regression report for the errors in rustc beta: rust-lang/rust#132000.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants