-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hugr-py): simplify hugr replacement #1194
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1194 +/- ##
==========================================
+ Coverage 86.58% 86.61% +0.03%
==========================================
Files 96 96
Lines 18046 18079 +33
Branches 16831 16831
==========================================
+ Hits 15625 15660 +35
+ Misses 1647 1645 -2
Partials 774 774
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@cqc-alec asking for re-review as the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
this exists as a tension between global/compositional building. Inter-graph edges necessitate global, all-at-once building for some cases.
These update functions are required when inserting graphs in to other onesInstead replaced withnew_nested
classmethods inspired by #1192 (comment)