Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hugr-py): simplify hugr replacement #1194

Merged
merged 2 commits into from
Jun 17, 2024
Merged

refactor(hugr-py): simplify hugr replacement #1194

merged 2 commits into from
Jun 17, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented Jun 13, 2024

this exists as a tension between global/compositional building. Inter-graph edges necessitate global, all-at-once building for some cases. These update functions are required when inserting graphs in to other ones Instead replaced with new_nested classmethods inspired by #1192 (comment)

@ss2165 ss2165 changed the title refactor: simplify hugr replacement refactor(hugr-py): simplify hugr replacement Jun 13, 2024
@ss2165 ss2165 marked this pull request as ready for review June 14, 2024 16:04
@ss2165 ss2165 requested a review from a team as a code owner June 14, 2024 16:04
@ss2165 ss2165 requested review from croyzor and removed request for a team June 14, 2024 16:04
@ss2165 ss2165 force-pushed the ss/replace-hugr branch from 72d4222 to 18dc93b Compare June 14, 2024 16:19
@ss2165 ss2165 removed request for croyzor and aborgna-q June 17, 2024 08:38
Base automatically changed from ss/build-node to main June 17, 2024 12:40
@ss2165 ss2165 force-pushed the ss/replace-hugr branch from 18dc93b to c59b5fa Compare June 17, 2024 13:38
@ss2165 ss2165 requested a review from cqc-alec June 17, 2024 13:40
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (1da33e6) to head (c59b5fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1194      +/-   ##
==========================================
+ Coverage   86.58%   86.61%   +0.03%     
==========================================
  Files          96       96              
  Lines       18046    18079      +33     
  Branches    16831    16831              
==========================================
+ Hits        15625    15660      +35     
+ Misses       1647     1645       -2     
  Partials      774      774              
Flag Coverage Δ
python 89.10% <100.00%> (+0.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ss2165
Copy link
Member Author

ss2165 commented Jun 17, 2024

@cqc-alec asking for re-review as the new new_nested approach is much simpler but quite different

@ss2165 ss2165 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 4ba4586 Jun 17, 2024
21 checks passed
@ss2165 ss2165 deleted the ss/replace-hugr branch June 17, 2024 13:45
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants