Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix failing unsoundness checks #1196

Merged
merged 4 commits into from
Jun 17, 2024
Merged

chore: Fix failing unsoundness checks #1196

merged 4 commits into from
Jun 17, 2024

Conversation

aborgna-q
Copy link
Collaborator

The unsoundness check was failing on main.

  • Skips the hugr-cli tests when running miri, as it does not support calling external processes.
  • Move impl Arbitrary for CustomSerialized out of a block of miri-skipped tests.
  • Adds a just miri command with the correct flags to get proptests working with miri.

CI run: https://github.com/CQCL/hugr/actions/runs/9518163988/job/26238422543

@aborgna-q aborgna-q requested a review from a team as a code owner June 14, 2024 15:35
@aborgna-q aborgna-q requested a review from doug-q June 14, 2024 15:35
@aborgna-q aborgna-q changed the title Ab/skip miri chore: Fix failing unsoundness checks Jun 14, 2024
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.58%. Comparing base (cbe31be) to head (8ad32d8).
Report is 1 commits behind head on main.

Current head 8ad32d8 differs from pull request most recent head 51b90fc

Please upload reports for the commit 51b90fc to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1196   +/-   ##
=======================================
  Coverage   86.58%   86.58%           
=======================================
  Files          94       94           
  Lines       17658    17658           
  Branches    16796    16796           
=======================================
  Hits        15289    15289           
  Misses       1600     1600           
  Partials      769      769           
Flag Coverage Δ
rust 86.44% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

justfile Outdated Show resolved Hide resolved
Copy link
Collaborator

@doug-q doug-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

.boxed()
}
#[cfg(test)]
mod proptest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is annoyingly non-uniform, everywhere else we have mod test::proptest, but it's fine. There's no reason to actually use this module anyway.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's a bit annoying. But the alternative is copying the skip attribute to all the internal test functions, and that seems more bothersome.

Co-authored-by: doug-q <[email protected]>
@aborgna-q aborgna-q added this pull request to the merge queue Jun 17, 2024
Merged via the queue into main with commit 0ee526a Jun 17, 2024
20 checks passed
@aborgna-q aborgna-q deleted the ab/skip-miri branch June 17, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants