-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix failing unsoundness checks #1196
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1196 +/- ##
=======================================
Coverage 86.58% 86.58%
=======================================
Files 94 94
Lines 17658 17658
Branches 16796 16796
=======================================
Hits 15289 15289
Misses 1600 1600
Partials 769 769
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
.boxed() | ||
} | ||
#[cfg(test)] | ||
mod proptest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is annoyingly non-uniform, everywhere else we have mod test::proptest
, but it's fine. There's no reason to actually use
this module anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's a bit annoying. But the alternative is copying the skip attribute to all the internal test functions, and that seems more bothersome.
Co-authored-by: doug-q <[email protected]>
The unsoundness check was failing on
main
.impl Arbitrary for CustomSerialized
out of a block of miri-skipped tests.just miri
command with the correct flags to get proptests working with miri.CI run: https://github.com/CQCL/hugr/actions/runs/9518163988/job/26238422543