Skip to content

Conversation

@aborgna-q
Copy link
Collaborator

If two instances of the release-plz workflow ran at the same time (due to multiple rust PRs being merged together), the newer one may try to update the release branch with stale ref info, and resort to re-creating the release PR instead.

This change avoids that situation by ensuring no two instances of the workflow run concurrently for the same branch.

@aborgna-q aborgna-q requested a review from a team as a code owner July 24, 2025 14:12
@aborgna-q aborgna-q requested a review from croyzor July 24, 2025 14:12
@aborgna-q
Copy link
Collaborator Author

Uhm, this may actually end up cancelling runs after a release PR is merged.

Since we set release_always = false in the config, later commits to main will not trigger the release so we may end up missing the publication 🤔

@aborgna-q aborgna-q force-pushed the ab/release-plz-concurrency branch from 5e15289 to 3b3db3b Compare July 25, 2025 10:33
@aborgna-q
Copy link
Collaborator Author

Ok, I split the PR-creating step from the registry-publish step and only added the concurrency limit to the former.
This should work directly now.

github-merge-queue bot pushed a commit to CQCL/tket2 that referenced this pull request Jul 25, 2025
Includes the changes from CQCL/hugr#2472 to
avoid release-plz closing release PRs due to dataraces.
jennyQuantinuum pushed a commit to CQCL/tket2 that referenced this pull request Jul 27, 2025
Includes the changes from CQCL/hugr#2472 to
avoid release-plz closing release PRs due to dataraces.
@aborgna-q aborgna-q added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit ab55539 Jul 30, 2025
21 checks passed
@aborgna-q aborgna-q deleted the ab/release-plz-concurrency branch July 30, 2025 11:45
croyzor pushed a commit to CQCL/tket2 that referenced this pull request Aug 11, 2025
Includes the changes from CQCL/hugr#2472 to
avoid release-plz closing release PRs due to dataraces.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants