Skip to content

feat: Add method to link Hugr modules (linking pt3 of >=4) #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 79 commits into
base: main
Choose a base branch
from
Open

feat: Add method to link Hugr modules (linking pt3 of >=4) #2529

Changes from all commits
Commits
Show all changes
79 commits
Select commit Hold shift + click to select a range
1723b48
Add HugrMut::insert_forest / insert_view_forest, implement insert_hug…
acl-cqc Aug 11, 2025
2e66542
insert_subgraph delegates to insert_forest (copying nodes list)
acl-cqc Aug 11, 2025
02fea73
errors; docs
acl-cqc Aug 11, 2025
fdee944
Tests
acl-cqc Aug 12, 2025
0eaf3eb
fix test - edges removed rather than delocalized
acl-cqc Aug 12, 2025
05072b6
Merge remote-tracking branch 'origin/main' into acl/insert_forest
acl-cqc Aug 12, 2025
f55c288
More docs/links
acl-cqc Aug 13, 2025
3621a7f
WIP
acl-cqc Aug 12, 2025
0f3883b
Dedup dfg_calling_defn_decl, start
acl-cqc Aug 12, 2025
865fdb8
Implement LinkHugr, split old insert_link_nodes -> check_directives+l…
acl-cqc Aug 12, 2025
54e87a0
Fix test, and note duplication
acl-cqc Aug 12, 2025
b522ff1
Common up insertion-checking in tests; expand doc
acl-cqc Aug 12, 2025
5774665
fix doclinks
acl-cqc Aug 13, 2025
7c41f73
Error on overlapping Add::replace; handle Add overlapping w/ UseExist…
acl-cqc Aug 13, 2025
e70015f
test multi-replace / replace+add
acl-cqc Aug 13, 2025
7001f9c
fix doc
acl-cqc Aug 13, 2025
698283c
NodeLinkingDirective::replace takes impl IntoIterator
acl-cqc Aug 13, 2025
18e1cf7
Avoid test nondeterminism; clippy
acl-cqc Aug 13, 2025
5e0cf33
Add NameLinkingPolicy+friends, and LinkHugr::link_hugr
acl-cqc Aug 13, 2025
c210f28
Remove copy_private_funcs; fix test to expect main
acl-cqc Aug 13, 2025
68a1ca6
Accessor/factory methods (need docs), enum SignatureConflictHandling
acl-cqc Aug 13, 2025
10778ce
Optimize by turning HashMap into impl IntoIterator, avoid size_hint
acl-cqc Aug 12, 2025
826990d
struct InsertedForest; use InsertForestResult alias more widely
acl-cqc Aug 15, 2025
f9eee44
N -> SN
acl-cqc Aug 15, 2025
caecc43
Make DoubleCopy contain a named field
acl-cqc Aug 15, 2025
bd12196
Revert "Make DoubleCopy contain a named field"
acl-cqc Aug 16, 2025
bdc0ff1
Use rstest::fixture
acl-cqc Aug 16, 2025
58dccdd
test tidy
acl-cqc Aug 16, 2025
b1c0d2a
add benchmark
acl-cqc Aug 17, 2025
88a4987
lint benchmark and add to criterion group
acl-cqc Aug 17, 2025
cb92e0c
comments
acl-cqc Aug 17, 2025
a73ce4f
Better benchmarks via iter_batched
acl-cqc Aug 19, 2025
481648e
Always convert to HashMap; update insert_forest_internal; roots->root…
acl-cqc Aug 19, 2025
9a9c325
Do not require HashMap, so insert_view_forest can avoid building one
acl-cqc Aug 19, 2025
ec01c36
Separate errors: DoubleCopy => DuplicateNode + SubtreeAlreadyCopied
acl-cqc Aug 19, 2025
8426498
docs
acl-cqc Aug 20, 2025
f8bdaa1
Builder docs for #2496
acl-cqc Aug 21, 2025
17a8de4
remove not-yet-existent doclink
acl-cqc Aug 21, 2025
191119f
Improve doc of dfg_calling_defn_decl
acl-cqc Aug 22, 2025
a3341df
Merge branch 'acl/insert_forest' into acl/insert_link_Nodes
acl-cqc Aug 25, 2025
351fa78
Rename Builder add_(hugr_=>)view_with_wires_link_nodes
acl-cqc Aug 25, 2025
871e26e
Rename LinkHugr => HugrLinking
acl-cqc Aug 25, 2025
ccc57ba
Rename insert_(hugr/from_view)_link_nodes => add_(hugr/view)_link_nodes
acl-cqc Aug 25, 2025
f3d0d84
Review suggestions (doc improvements)
acl-cqc Aug 25, 2025
3438e5e
doc: HugrLinking: add _static_ edges between old and inserted nodes
acl-cqc Aug 25, 2025
050f40d
Merge branch 'acl/insert_link_nodes' into acl/link_hugr
acl-cqc Aug 25, 2025
3de64e8
Move accessors, document
acl-cqc Aug 25, 2025
2a6f33a
Improve docs: module-children, not necessarily funcdefn/decl
acl-cqc Aug 25, 2025
8c7ef87
Merge branch 'acl/insert_link_nodes' into acl/link_hugr (docs)
acl-cqc Aug 25, 2025
8c16c66
Rename link_hugr to link_module, add link_module_view
acl-cqc Aug 25, 2025
e5432cc
link_xyz take &NameLinkingPolicy; refactor tests
acl-cqc Aug 25, 2025
fd02eab
clippy
acl-cqc Aug 25, 2025
347f96d
newer clippy
acl-cqc Aug 25, 2025
ff8d6ea
Handle Constants, update test
acl-cqc Aug 25, 2025
d3f95df
doclinks
acl-cqc Aug 26, 2025
685e19f
insert_view_forest uses iter_batched and recreates host each time
acl-cqc Sep 1, 2025
57e58e2
oops, fix borrow in bench
acl-cqc Sep 1, 2025
6850d9d
Merge remote-tracking branch 'origin/main' into acl/insert_forest
acl-cqc Sep 2, 2025
eac8d74
Merge branch 'acl/insert_forest' into acl/insert_link_nodes
acl-cqc Sep 2, 2025
5979bf6
Add ModuleBuilder::add_{hugr,view}_link_nodes
acl-cqc Sep 2, 2025
1a3e37a
ModuleBuilder::add_(hugr/view)_link_nodes => link_(hugr/view)_by_node
acl-cqc Sep 3, 2025
cc861fa
HugrMut methods are insert_link_(hugr/view)_by_node
acl-cqc Sep 4, 2025
0de1326
Dataflow builder: add_link_(hugr/view)_by_node_with_wires
acl-cqc Sep 4, 2025
97b3bf1
doclinks
acl-cqc Sep 4, 2025
a1f9a1e
SignatureConflictHandling -> NewFuncHandling, MultipleImplHandling::A…
acl-cqc Sep 5, 2025
2d11a69
...and fix docs
acl-cqc Sep 5, 2025
2bee21f
on_multiple_impls / on_signature_conflict return &mut
acl-cqc Sep 5, 2025
158fcfd
NameLinkingPolicy mutators are self->Self
acl-cqc Sep 14, 2025
82759b5
NodeLinkingDirective is non-exhaustive
acl-cqc Sep 14, 2025
2c00827
Merge branch 'acl/insert_link_nodes' into HEAD
acl-cqc Sep 15, 2025
0d9db3a
Add struct LinkerActions
acl-cqc Sep 14, 2025
0c49003
Revert; add enum LinkAction (and map thereof)
acl-cqc Sep 15, 2025
70b4e3f
Review comment be more imperative
acl-cqc Sep 16, 2025
3193ea4
Merge remote-tracking branch 'origin/main' into acl/insert_link_nodes
acl-cqc Sep 16, 2025
c3bcbc9
Merge branch 'acl/insert_link_nodes' into acl/link_hugr
acl-cqc Sep 16, 2025
a76c37c
Drop Visibility::is_public, single callee and better to inline
acl-cqc Sep 16, 2025
23e680a
Use derive_more::From
acl-cqc Sep 16, 2025
2a608df
Drop S: ?Sized on to_node_linking
acl-cqc Sep 16, 2025
5ca0e5f
Add LinkAction From<NodeLinkingDirective>
acl-cqc Sep 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading