Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add RZZ and Reset operations #2

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

irfankhan10
Copy link

Adding native gates from qsharp to the _GATE_SET list:

  1. RZZ: https://learn.microsoft.com/en-us/qsharp/api/qsharp-lang/microsoft.quantum.intrinsic/rzz
  2. Reset: https://learn.microsoft.com/en-us/qsharp/api/qsharp-lang/microsoft.quantum.intrinsic/reset

Above, 1. is needed for arbitrary angle two-qubit gates and 2. is needed for MCMR.

Related issues

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@irfankhan10 irfankhan10 requested a review from cqc-alec as a code owner July 16, 2024 15:21
@@ -60,6 +60,8 @@ def _get_workspace(
OpType.X,
OpType.Y,
OpType.Z,
OpType.ZZPhase,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately when we convert a circuit containing a ZZPhase gate to QIR using qiskit_qir.to_qir_module(), the gate is converted to two CX gates and an Rz. So there is no point including it here -- we may as well do the rebase ourselves. This means that circuits submitted to Quantinuum devices will not be in the native gate set, and we have to rely on rebasing at the other end. This situation should improve when pytket-qir can handle the conversions ( CQCL/pytket-qir#152 ).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will wait for this to be supported.

@irfankhan10 irfankhan10 marked this pull request as draft July 17, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants