Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kwarg on process_circuits to cutomise job_name_prefix #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

irfankhan10
Copy link

Description

Option to add custom prefix to job names.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@irfankhan10 irfankhan10 requested a review from cqc-alec as a code owner July 19, 2024 15:42
"""
option_params = kwargs.get("option_params")
job_name_prefix = kwargs.get("job_name_prefix", "job")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value doesn't match what is stated in the docstring. Did you want to change this to "azure-quantum-job"? (The "azure-quantum" part seems redundant to me, but happy to go with that if you think it's helpful.)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I can add back. I changed to azure-quantum-job, but then changed back to job but forgot to update the string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants