add wasm support to the conversion #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Solved #65 and adds the wasm support |
cqc-melf
commented
Aug 16, 2023
|
|
||
| initial_result = str(populated_module.module.ir()) # type: ignore | ||
|
|
||
| initial_result = ( |
There was a problem hiding this comment.
It is probably easier to understand this when looking at the individual commits
cqc-alec
approved these changes
Aug 16, 2023
| wasm_func_interface += f"i{self.int_type_str} " | ||
| else: | ||
| raise ValueError( | ||
| "wasm function which return more than" |
There was a problem hiding this comment.
I guess we should make an issue for this?
There was a problem hiding this comment.
Yes I will do that
There was a problem hiding this comment.
Done at CQCL/pytket-quantinuum#201
I have added that to pytket-quantinuum because this is an issues that needs to be solved for qasm, qir and on the hardware side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.