Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update backend_test.py #254

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update backend_test.py #254

merged 1 commit into from
Oct 12, 2023

Conversation

cqc-melf
Copy link
Collaborator

I don't see a file with the 2 in the name on develop at the moment?

@cqc-melf cqc-melf requested a review from yao-cqc as a code owner October 12, 2023 15:28
@cqc-melf cqc-melf requested a review from cqc-alec October 12, 2023 15:28
cqc-alec
cqc-alec approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that was my mix-up, thanks for spotting.

@cqc-melf
Copy link
Collaborator Author

For me this works locally, I will not wait for the QA test, any objections? @cqc-alec

@cqc-alec
Copy link
Collaborator

For me this works locally, I will not wait for the QA test, any objections? @cqc-alec

Sure we can merge this.

@cqc-melf cqc-melf merged commit 0ddba65 into develop Oct 12, 2023
9 of 10 checks passed
@cqc-melf cqc-melf deleted the fix/wasm-multi-file branch October 12, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

@yao-cqc yao-cqc Awaiting requested review from yao-cqc yao-cqc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cqc-melf @cqc-alec