Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/global footer #26

Merged
merged 20 commits into from
Oct 3, 2024
Merged

Feat/global footer #26

merged 20 commits into from
Oct 3, 2024

Conversation

irfankhan10
Copy link
Collaborator

@irfankhan10 irfankhan10 commented Sep 30, 2024

Add a global footer with fixed columns and column entries. Also added a link to Quantinuum Trademark guidelines.

image

@irfankhan10 irfankhan10 requested a review from aidanCQ September 30, 2024 16:23
@aidanCQ
Copy link
Collaborator

aidanCQ commented Oct 1, 2024

Product specific links are still in use in other sites so we can't hardcode the entire footer.

Screenshot 2024-10-01 at 10 01 45

@irfankhan10 irfankhan10 requested a review from aidanCQ October 3, 2024 14:07
@irfankhan10
Copy link
Collaborator Author

Product specific links are still in use in other sites so we can't hardcode the entire footer.

Screenshot 2024-10-01 at 10 01 45

We agreed all global footers would contain non-customizable content.

commit f982431
Merge: ed1e978 34f9064
Author: Irfan Khan <[email protected]>
Date:   Thu Oct 3 15:21:06 2024 +0100

    Merge branch 'feat/global_footer' of https://github.com/CQCL/quantinuum-ui into feat/global_footer

commit ed1e978
Author: Irfan Khan <[email protected]>
Date:   Thu Oct 3 15:19:44 2024 +0100

    change title to name and specify column as property of FooterConfig

commit d203c5e
Author: Irfan Khan <[email protected]>
Date:   Thu Oct 3 15:18:48 2024 +0100

    remove unneeded subtitle

commit 34f9064
Author: aidanCQ <[email protected]>
Date:   Thu Oct 3 15:17:58 2024 +0100

    Remove domain from intralinks.

commit 60c1a3a
Author: aidanCQ <[email protected]>
Date:   Thu Oct 3 15:17:00 2024 +0100

    Fix type errors.

commit c35745f
Author: aidanCQ <[email protected]>
Date:   Thu Oct 3 15:16:55 2024 +0100

    Add lint to ci.

commit 1204910
Author: Irfan Khan <[email protected]>
Date:   Thu Oct 3 15:06:02 2024 +0100

    Add forward slash after second legal entry

commit 1c7d0e1
Author: Irfan Khan <[email protected]>
Date:   Thu Oct 3 15:03:30 2024 +0100

    remove {props.subtitle} and add Trademark Guidelines

commit a38ca41
Author: Irfan Khan <[email protected]>
Date:   Thu Oct 3 15:02:55 2024 +0100

    delete redundent file

commit 4478a0e
Author: irfankhan10 <[email protected]>
Date:   Tue Oct 1 16:08:33 2024 +0100

    Delete src/custom/docs/components/footer/text.json

    delete unneeded text.json

commit 774acd5
Author: Irfan Khan <[email protected]>
Date:   Mon Sep 30 18:45:03 2024 +0200

    use footerConfig within TSX function

commit 8164624
Author: Irfan Khan <[email protected]>
Date:   Mon Sep 30 18:44:19 2024 +0200

    remove redundant code

commit 693031e
Author: Irfan Khan <[email protected]>
Date:   Mon Sep 30 18:41:41 2024 +0200

    correct indentation

commit 71b7c82
Author: Irfan Khan <[email protected]>
Date:   Mon Sep 30 18:41:12 2024 +0200

    move Footer Schema and Content into index.tsx

commit fa8a483
Author: Irfan Khan <[email protected]>
Date:   Mon Sep 30 18:21:39 2024 +0200

    parse footercontent and map to typescript function

commit f9de06c
Author: Irfan Khan <[email protected]>
Date:   Mon Sep 30 18:21:16 2024 +0200

    textual footer content

commit e32a714
Author: Irfan Khan <[email protected]>
Date:   Mon Sep 30 18:21:09 2024 +0200

    define schema for footer content
@aidanCQ aidanCQ merged commit 9b79b4e into main Oct 3, 2024
1 check passed
@irfankhan10 irfankhan10 deleted the feat/global_footer branch October 3, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants