Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken crosslinks to user guide #1571

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

CalMacCQ
Copy link
Contributor

Description

Fixed some broken links to the user guide. These were caused by the changes in CQCL/pytket-docs#339

Not so happy with this fix as I'm still using the full URL links

It should be possible to link to subsections of the docs using intersphinx and sphinx-autosectionlabel but I couldn't quite get it to work yet. This would mean that the full URL would only be written in the conf.py and it would be easy to get more robust linking. In the event of a URL change we could only update the link in a single place.

The autoforwarding from the old links also doesn't seem to be working properly so at least this PR addresses the link breakage for now.

Related issues

Please mention any github issues addressed by this PR.

Checklist

  • I have performed a self-review of my code.
  • I have commented hard-to-understand parts of my code.
  • I have made corresponding changes to the public API documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the changelog with any user-facing changes.

@CalMacCQ CalMacCQ requested a review from cqc-alec September 10, 2024 16:46
README.md Outdated Show resolved Hide resolved
@@ -3,11 +3,11 @@ pytket.backends

Contains :py:class:`Backend` abstract class and associated methods. In pytket a :py:class:`Backend` represents an interface between pytket and a quantum device or simulator. Different backends are defined in the various pytket extension modules and inherit from the core pytket :py:class:`Backend` class.

There are several `example notebooks <https://tket.quantinuum.com/examples>`_ on pytket :py:class:`Backend`\s. If you are interested in developing your own :py:class:`Backend` or pytket extension then see the `creating backends <https://tket.quantinuum.com/examples/creating_backends.html>`_ tutorial.
There are several `example notebooks <https://tket.quantinuum.com/examples>`_ on pytket :py:class:`Backend`\s. If you are interested in developing your own :py:class:`Backend` or pytket extension then see the `creating backends <https://tket.quantinuum.com/user-guide/examples/creating_backends.html>`_ tutorial.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get 404 with this URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting... fixed in e197d77

@CalMacCQ CalMacCQ requested a review from cqc-alec September 12, 2024 08:47
@CalMacCQ CalMacCQ merged commit 4ca041b into main Sep 12, 2024
30 checks passed
@CalMacCQ CalMacCQ deleted the docs/fix_user-guide_links branch September 12, 2024 09:07
CalMacCQ added a commit that referenced this pull request Sep 13, 2024
* fix: broken crosslinks to user guide

* Update README.md

Co-authored-by: Alec Edgington <[email protected]>

* fix creating backends link

---------

Co-authored-by: Alec Edgington <[email protected]>
CalMacCQ added a commit that referenced this pull request Sep 13, 2024
* fix: broken crosslinks to user guide (#1571)

* fix: broken crosslinks to user guide

* Update README.md

Co-authored-by: Alec Edgington <[email protected]>

* fix creating backends link

---------

Co-authored-by: Alec Edgington <[email protected]>

* docs: use latest version of theming submodule (#1574)

* bump submodule

* Revert "bump submodule"

This reverts commit 063de1d.

---------

Co-authored-by: Alec Edgington <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants