Deprecate GlobalisePhasedX
#1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-melf
reviewed
Nov 18, 2024
pytket/binders/passes.cpp
Outdated
| @@ -499,6 +508,7 @@ PYBIND11_MODULE(passes, m) { | |||
| "performance. If squashing is disabled, each non-global PhasedX gate " | |||
| "will be replaced with two global NPhasedX, but any other gates will " | |||
| "be left untouched." | |||
| "\n\nDEPRECATED: This pass will be removed after pytket version 1.39." | |||
There was a problem hiding this comment.
Do we want to put a specific version, or maybe better a more specific date?
There was a problem hiding this comment.
Intentionally put "after" so as not to be too committal, if we don't want to actually remove it.
There was a problem hiding this comment.
Maybe a date would be better though.
cqc-melf
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1682 .