Fix errors after stub typing PR #994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The check that this fixes the wheel build is running here: https://github.com/CQCL/tket/actions/runs/6039343076 |
cqc-alec
approved these changes
Aug 31, 2023
cqc-alec
reviewed
Aug 31, 2023
cqc-alec
requested changes
Aug 31, 2023
trvto
force-pushed
the
fix-pytket-tests
branch
from
862e326 to
e263953
Compare
|
Yep I hope I got them all now |
cqc-alec
previously approved these changes
Aug 31, 2023
cqc-alec
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made
pytket.testsa package to more easily satisfymypy, but that broke the build wheel and test CI for some reason. This makespytket.testsnot a package again. After reading up here, having tests as a package is not good practice anyway (it would be okay if we had the pytket package undersrc/pytketinstead of justpytket).Also there is a weird error that occurs only on MacOS 11, where the
EdgeTypeenum takes nonsensical values within the pythonutils_serialization.pyteststest_diag.... As a workaround, return edge type strings in the functionCircuit()._dag_datainstead ofEdgeTypeenum object.