Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split atmostpheric products by variables and time for cop_cds and ecmwf #826

Closed

Conversation

jlahovnik
Copy link
Collaborator

@jlahovnik jlahovnik commented Sep 14, 2023

  • adds the "split configuration" for the cop cds and ecmwf provider
  • splitting is added for the cds and ecmwf api plugin
  • products can be split by year or by month (currently one month configured for both providers)
  • one asset per selected/available parameter is created
  • handling of constraints with either select boxes for year, month, day or date ranges available
  • constraint file for ERA5_SL collection is added (only product type configured for cop_cds); currently no constraints for TIGGE_CF_SFC (only collection configured for ecmwf) available

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Test Results

       4 files  ±  0         4 suites  ±0   6m 3s ⏱️ - 1m 1s
   442 tests +15     439 ✔️ +15    3 💤 ±0  0 ±0 
1 768 runs  +60  1 692 ✔️ +56  76 💤 +4  0 ±0 

Results for commit 3f3b75a. ± Comparison against base commit db336eb.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Code Coverage (Ubuntu)

File Coverage
All files 82%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 3f3b75a

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

Code Coverage (Windows)

File Coverage
All files 77%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 3f3b75a

@jlahovnik jlahovnik changed the title Split atmostpheric products by variables and time for cop_cds Split atmostpheric products by variables and time for cop_cds and ecmwf Sep 15, 2023
@jlahovnik jlahovnik linked an issue Sep 15, 2023 that may be closed by this pull request
2 tasks
introduces functions that will split a timespan into defined slices based on the configuration and given constraints
functions to create slices given by dates + some fixes
create one product per time slice and one asset per variable if config is done accordingly
fixes to make the download of ecmwf assets work + add date constraints support
fix format of day and month, do not split short timespans, check constraints before download
@jlahovnik jlahovnik force-pushed the split-atmostpheric-products-by-variables-and-time-cds branch from e6f453b to baccbe9 Compare September 18, 2023 14:44
@jlahovnik
Copy link
Collaborator Author

changes in #889

@jlahovnik jlahovnik closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant