Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validation for query params #949

Closed
wants to merge 1 commit into from
Closed

feat: add validation for query params #949

wants to merge 1 commit into from

Conversation

bjgiraudon
Copy link
Collaborator

Description

This PR adds validation to the queryable parameters, using Pydantic.

@bjgiraudon bjgiraudon added enhancement New feature or request dedl DEDL related labels Dec 5, 2023
@bjgiraudon bjgiraudon requested a review from sbrunato December 5, 2023 12:17
@bjgiraudon bjgiraudon self-assigned this Dec 5, 2023
@bjgiraudon bjgiraudon linked an issue Dec 5, 2023 that may be closed by this pull request
query parameters validation #942
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 5, 2023

Test Results

    1 files   -        3      1 suites   - 3   48s ⏱️ - 2m 39s
433 tests ±       0  426 ✔️  -        4  3 💤 ±  0  4 ❌ +4 
433 runs   - 1 299  426 ✔️  - 1 230  3 💤  - 73  4 ❌ +4 

For more details on these failures, see this check.

Results for commit 571a129. ± Comparison against base commit a6be03b.

@bjgiraudon bjgiraudon marked this pull request as draft December 7, 2023 08:38
@sbrunato sbrunato assigned jlahovnik and unassigned bjgiraudon Mar 8, 2024
@jlahovnik jlahovnik closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunato sbrunato Awaiting requested review from sbrunato

Assignees

@jlahovnik jlahovnik

Labels
dedl DEDL related enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

query parameters validation
2 participants
@bjgiraudon @jlahovnik