-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: JWT Backend Storage, JWT Bugs #136
Conversation
… typecast, which is unsafe.
…, fetch access token when expired whenever page changes
…, fetch access token when expired whenever page changes
… then see user details, after that works every time
…se-assessment-g17 into update-jwt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't see any errors - looks good - maybe merge and see what happens on deployment
the 10s token thing... isnt permanent right?
regarding the 10s token thing, it is not permanent. It is just to see that the thing overall works for the ones covered by JWT. But let's be real, the presentation and stuff is too easy to mess up. Just to play it superrrr safe, I'll place it at 1h expiry time. |
To fix in future PR, NOT HERE:
I think this bug was always there, in latest commit here:
mostly works for jwt, bug: need to refresh profile page upon login to then see user details, after that works every time