Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
# Conflicts: # peer-prep-fe/src/app/app.routes.ts
* collab-page: Add collab page Add duplicate check to Update Question Fix Question-page Sort button dropdown css Add login guards, fix admin page button not showing when refresh
* aiden_M5: Add git ignore Hardcode acceptMatch Integrate with collab page Code collab Code Collab
* main: (21 commits) Update app.component.html Accept timer message bug fix Fix question history deployment Deployment fix - chat service Remove console logs Fix when user clicks back button, users are navigated back to matching. Current fix now navigates user back to landing page Added API to allow user to cancel match request Fixed bug where ChangeStream threw error when one user times out Fix ui for add and edit modal Fix Add loading spinner when logging in Fix loading of messages Remove accessibility to question-list if not logged in Edit webSocket URI Return function Merge conflict Edit Websocket Edit WebSocket Edit Websocket Add name ...
Update repository.js
Fix landing page error
* main: Fix landing page error Accept timer message bug fix Fix question history deployment
Updated duplication validation in Create and Update question
Remove unused code
WebSocket ping ping ping
Lynn final fixes
* main: Updated duplication validation in Create and Update question Fix margin Syntax spacing Add heartbeat to keep websocket alive
Fix add/edit modal
Change error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @AidenLYT @Teeesa7 @kervyntan @smolegz @lynnetteeee