Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submission & disconnection logic; bugfixes #40

Merged
merged 6 commits into from
Nov 9, 2024
Merged

Submission & disconnection logic; bugfixes #40

merged 6 commits into from
Nov 9, 2024

Conversation

Singa-pirate
Copy link

@Singa-pirate Singa-pirate commented Nov 9, 2024 •
edited
Loading

Features

  • Disconnect user and return to home page when partner submits code

Bugfixes

  • Fixed issue that matching service occasionally returns wrong room number
  • Fixed issue with videocall after both user reconnect

@Singa-pirate Singa-pirate mentioned this pull request Nov 9, 2024
Closed
@Singa-pirate Singa-pirate mentioned this pull request Nov 9, 2024
Closed
@Singa-pirate Singa-pirate marked this pull request as ready for review November 9, 2024 13:26
@Singa-pirate Singa-pirate changed the title [WIP] Submission & disconnection logic; bugfixes Submission & disconnection logic; bugfixes Nov 9, 2024
dedsecrattle
dedsecrattle approved these changes Nov 9, 2024
View reviewed changes
Copy link

@dedsecrattle dedsecrattle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dedsecrattle dedsecrattle merged commit d9e6867 into main Nov 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dedsecrattle dedsecrattle dedsecrattle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Singa-pirate @dedsecrattle