Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend for question service #6

Merged
merged 24 commits into from
Sep 27, 2024
Merged

Frontend for question service #6

merged 24 commits into from
Sep 27, 2024

Conversation

Singa-pirate
Copy link

Components

  • Navbar, Footer
  • QuestionList
    • GET questions on page load
    • Buttons for other REST api calls
    • Supports sorting
  • Dialogs
    • MainDialog: to display information, only has an "OK" button
    • ConfirmationDialog: has options to "Confirm" or "Cancel", can configure a callback function upon confirmation
    • QuestionDialog: has input fields for updating a question

Services

  • QuestionService to handle GET, POST, PUT and DELETE api calls to backend
    • Validation & Parsing helpers are in util folder

Styles

  • MUI theme is defined in App.tsx. In general,
    • texts should be wrapped in <Typography> tag to use font and color in the theme
    • primary/secondary buttons should have e.g. color="primary" variant="contained"

Copy link

@dedsecrattle dedsecrattle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dedsecrattle dedsecrattle merged commit 802b73f into dev Sep 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants