Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement edit user feature for admins #114

Merged
merged 15 commits into from
Sep 26, 2024

Conversation

jq1836
Copy link

@jq1836 jq1836 commented Sep 23, 2024

Resolves #13

Overview

Add in feature to allow admin users to update username/email of any user.

Changelog

  • Added modal which pops up when admin user clicks on edit button in admin user management page
  • Updated edit button in admin user management page to use pencil icon
  • Updated delete button in admin user management page to use trashcan icon
  • Added the following files:
    • admin-edit-user-modal.tsx
    • update-user.tsx

@jq1836 jq1836 self-assigned this Sep 23, 2024
Copy link

@wr1159 wr1159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Works as intended, is it weird that we can't change the skillLevel though?

@jq1836
Copy link
Author

jq1836 commented Sep 26, 2024

LGTM Works as intended, is it weird that we can't change the skillLevel though?

Yeah its abit weird, maybe lets discuss this during meeting, but probably okay to merge for now

@wr1159 wr1159 merged commit e9c1c30 into main Sep 26, 2024
1 check passed
@wr1159 wr1159 deleted the feature/user-service/admin-edit-user branch September 26, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

F1.3.4 The service shall allow admin users to update the username and email address of all users.
2 participants