Fix duplicate handling in update questions backend #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jq1836
requested changes
Sep 26, 2024
jq1836
reviewed
Sep 26, 2024
| @@ -39,14 +39,22 @@ async def delete_question(question_id: str): | |||
|
|
|||
| async def update_question_by_id(question_id: str, question_data: UpdateQuestionModel): | |||
There was a problem hiding this comment.
Would be difficult to identify what this function returns. Currently, it can return None, str and QuestionModel which may make it difficult to understand the code
There was a problem hiding this comment.
Yep, we need some form error handling for this and other end points too. Instead of returning None/str, should throw error instead
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the update question endpoint failed to check for duplicate title in the database, allowing for duplicates titles to be stored in the database.
Changes made