Add API gateway #167
Merged
Add API gateway #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To review after PR #166 |
Simongolovinskiy
approved these changes
Oct 15, 2024
SelwynAng
reviewed
Oct 17, 2024
There was a problem hiding this comment.
LGTM overall, aside from some comments.
Also, should we set the API gateway port to some fixed value instead of making it flexible? Tested with 8080 and 2000, those port numbers don't allow the frontend to communicate with the backend services. Port numbers like 80 and 1234 work though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14, #19, #20, #24
Overview
Previously, our question service was exposed, allowing anyone to use the endpoints. The API gateway provides automatic authentication, as well as provides ingress capabilities.
Currently does not provide load balancing capabilities. Intention is for load balancing to be done by k8s.
Testing instructions
API_GATEWAY_PORTvalue to.env. Note that whatever port you set here will determine how you access the pages.localhost:$API_GATEWAY_PORTto access frontend.