Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix login failed toast vague message #176

Merged
merged 3 commits into from
Oct 20, 2024
Merged

Fix login failed toast vague message #176

merged 3 commits into from
Oct 20, 2024

Conversation

SelwynAng
Copy link

Resolves #160.

jq1836
jq1836 approved these changes Oct 18, 2024
View reviewed changes
Copy link

@jq1836 jq1836 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should technically work, assuming we call the endpoint accurately, so LGTM. I have added some suggestions for how we can improve on this to make it safer.

frontend/components/auth/login-form.tsx Outdated Show resolved Hide resolved
@SelwynAng SelwynAng force-pushed the fix/bug/login-fail-toast branch from 92d68a4 to d5b092f Compare October 19, 2024 05:13
@SelwynAng SelwynAng merged commit c13d229 into main Oct 20, 2024
2 checks passed
@SelwynAng SelwynAng deleted the fix/bug/login-fail-toast branch October 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jq1836 jq1836 jq1836 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

login failed toast should be clearer
2 participants
@SelwynAng @jq1836