Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend-Backend matching integration #178

Merged
merged 10 commits into from
Oct 20, 2024
Merged

Conversation

jq1836
Copy link

@jq1836 jq1836 commented Oct 18, 2024

Overview

Integrated matching frontend with backend.

Behaviour

Typical

    1. User 1 join queue
    2. User 2 join queue
    3. User 1 match with user 2
test1.mp4
    1. User 1 join queue
    2. User 1 leave queue
    3. User 2 join queue
    4. User 2 leave queue
test2.mp4

Atypical

    1. User 1 join queue
    2. User 1 join queue on another tab
    3. User 2 join queue
    4. User 1 match with user 2
test3.mp4
    1. User 1 join queue
    2. User 1 join queue on another tab
    3. User 1 leave queue
    4. Other tab automatically leaves queue
test4.mp4

@jq1836 jq1836 self-assigned this Oct 18, 2024
Copy link

@wr1159 wr1159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general, tested the application and it does work as intended

More documentation would be great thought regarding the lock stuff but anyways not requried

@wr1159
Copy link

wr1159 commented Oct 20, 2024

LGTM

@wr1159 wr1159 merged commit c917346 into main Oct 20, 2024
2 checks passed
@wr1159 wr1159 deleted the feat/matching/backend-integration branch October 20, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants