Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up common room logic in preparation for collaboration service #182

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Set up common room logic in preparation for collaboration service #182

merged 2 commits into from
Oct 31, 2024

Conversation

SelwynAng
Copy link

Changes Made:

  • Matching service updated to include the generation of a common room ID for matched users
  • find-match.tsx in frontend updated to redirect matched users to a placeholder collaborative room with common room ID

dylkaw
dylkaw approved these changes Oct 31, 2024
View reviewed changes
Copy link

@dylkaw dylkaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dylkaw dylkaw merged commit 6ab7b07 into main Oct 31, 2024
2 checks passed
@dylkaw dylkaw deleted the set-up-collab-service-frontend branch October 31, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylkaw dylkaw dylkaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SelwynAng @dylkaw