Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collab page #183

Merged
merged 28 commits into from
Nov 3, 2024
Merged

Add collab page #183

merged 28 commits into from
Nov 3, 2024

Conversation

dylkaw
Copy link

@dylkaw dylkaw commented Oct 31, 2024

Basic frontend for collab room.
image

TODO:

  • Passing of topic, difficulty to collab room upon match
  • Fetching of random question after match
  • Access control, ensuring only matched users can access the corresponding room

Bugs/Improvements:

  • Chat does not display the most recent message when switching between partner and AI chat
  • Part of chat component cut off on smaller screens, have to scroll

@SelwynAng SelwynAng force-pushed the feat/collab-service/collab-page branch from 3014d4d to 6050f39 Compare November 2, 2024 17:39
try {
// Remove any existing rooms where either user1 or user2 is a participant
await UsersSession.deleteMany({ users: { $in: [user1, user2] } });
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this if we're implementing the past rooms history feature

Comment on lines +13 to +16
<Button variant="destructive">
Leave Room
<X className="ml-2" />
</Button>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's meant to be non-functional for now right?

Copy link

@wr1159 wr1159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only a few nits

@SelwynAng SelwynAng merged commit e500d98 into main Nov 3, 2024
2 checks passed
@SelwynAng SelwynAng deleted the feat/collab-service/collab-page branch November 3, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants