Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sum sumBy and CountIf functionality to ResArr #41

Merged
merged 3 commits into from
Dec 11, 2023

Conversation

DoganCK
Copy link
Contributor

@DoganCK DoganCK commented Nov 1, 2023

Added simple functionality to ResizeArray.
They will help Graphoscope code to be more readable and performant.

Copy link
Member

@kMutagene kMutagene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DoganCK, thanks for the additions. Could you add some basic tests accompanying this PR?

@DoganCK
Copy link
Contributor Author

DoganCK commented Nov 4, 2023

Sure @kMutagene just added them.

Copy link
Member

@kMutagene kMutagene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! last request i promise :D

Could you add xml documentation above the functions, also documenting the parameters? See

/// <summary>Views the collection as an enumerable sequence of pairs.
/// The sequence will be ordered by the keys of the dictionary.</summary>
/// <param name="table">The input dictionary.</param>

for example. I know the other functions in this module completely lack this, but let's lead by example 😆

@DoganCK
Copy link
Contributor Author

DoganCK commented Nov 6, 2023

Sure @kMutagene, that's a good idea! I've added docs for the three functions.
Planning to add more but I'll create a new PR for those.

By the way this is a really useful library, any plans to move it over to FsLab?

Copy link
Member

@kMutagene kMutagene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DoganCK !

Happy that you find the lib useful. I have not thought about moving it to fslab because it lacks a data science specific focus, we can however discuss this further.

@kMutagene kMutagene merged commit 35517d8 into CSBiology:main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants