Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Registration Refactoring #34

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

User Registration Refactoring #34

wants to merge 15 commits into from

Conversation

Madhavan7
Copy link
Contributor

Refactored the code related to User Registration and User Login. User Login now follows MVP architectural pattern.

@Madhavan7 Madhavan7 linked an issue Dec 2, 2022 that may be closed by this pull request
[Feature 1] User Registration #9
Open
milkdromeda
milkdromeda previously approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@milkdromeda milkdromeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Madhav, your Javadoc and comments makes reviewing easier, so thank you. I mainly focused on your tests and did not have a chance to check all dependencies.

src/test/java/test_user_registration/TestUserExistsInteractor.java Show resolved Hide resolved
src/test/java/test_user_registration/TestUserExistsInteractor.java Show resolved Hide resolved
amyyong11
amyyong11 previously approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@amyyong11 amyyong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think your code looks pretty clean ~ nice jobb! I noticed that in your code you get the chats, so I don't think I'll need UserAppScreenGateway's login method then, so I'll delete that

src/main/java/screens/login_screen/UserLoginUI.java Show resolved Hide resolved
src/main/java/screens/user_registration_screen/UserRegistrationUI.java Show resolved Hide resolved
src/main/java/screens/login_screen/AppScreenCreator.java Show resolved Hide resolved
@Madhavan7 Madhavan7 dismissed stale reviews from amyyong11 and milkdromeda via 5c3d0fc December 3, 2022 00:38
amyyong11
amyyong11 approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@amyyong11 amyyong11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogolsahebi sogolsahebi sogolsahebi approved these changes

@amyyong11 amyyong11 amyyong11 approved these changes

@milkdromeda milkdromeda milkdromeda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature 1] User Registration
4 participants
@Madhavan7 @milkdromeda @amyyong11 @sogolsahebi