Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
…PI; created Angular front end pages. Specific Changes Made: * Enabled CORS for API. * feat: Added an endpoint to API to verify that the entered email is valid * feat: Added an endpoint to register student accounts on Firebase and update SQL database. (#9) * Added endpoint /api/Accounts/v1/student/register for YS-52. * build: Added router and subpages * feat: Added registration UI * feat: Added routing and registration UI * feat: added all subpages (#14) * YS-32 Added api/Accounts/v1/login endpoint to process user log ins and return and JWT token. * YS-66 added authentication capabilities to API using JWT auth tokens. * YS-72 added extra claims into the Firebase JWT to store user role. * feat: Added Login UI (#20) * YS-30: created UI for login page * YS-30: added authentication to login page * YS-30: added redirect upon successful login * YS-30: fixed consistency with other pages * YS-39 Added endpoint to send the user a password reset link to their email. * Added company object (#18) * Added school object (highschool) (#23) * feat: Add Student dashboard to UI. * Added employer dashboard. * YS-35: added reset password page and added logic to handle reset (#30) * Added endpoint to check company existence (#24) * Added endpoint for employer registration (#27) * Feat: added UI logic to redirect different users upon login (#21) * YS-31: added UI logic for different user types * Added front end Company and Employee registration (#31) * feat: Add Admin dashboard to UI. (#29)
* docs: Adding system design document word file. * Initial creation of endpoints documentation markdown. * docs: Updated endpoints.md to include student registration, login, and send password reset email. * ci: added job tables * refactor: Added ApiResponse object for consistent API returns. * fix: added dependency "jwt-decode" (#37) * feat: Updating the Events table in SQL db. * refactor: Updated ApiResponse.cs class to include more fields and a constructor. * refactor: Updated ApiResponse.cs class to include more fields and a constructor. * refactor: Included exceptions field in ApiResponse.cs and added serialization ability. * package: Installing Newtonsoft Json package to serialize API returns. * YS-106 - Updated login endpoint to return ApiResponse object. * YS-102 - refactor check email registered api to return ApiResponse object. * YS-103 - refactor send password reset email to return ApiResponse object. * YS-104 - refactored student registration to return ApiResponse object. * feat: Added endpoints for job postings (#36) * Added endpoints for job postings * postings now properly give user info * added exception message * removed merge comments --------- Co-authored-by: Cosmo48 <[email protected]> * YS-78 - Created endpoints to delete and create events. * YS-112 - Updated API to return ApiResponse object on auth fail. * docs: Updated endpoints.md to include information about ApiResponse object and Authentication. * docs: Updating endpoints.md * docs: updates to endpoints.md * feat: added profile page for students (#35) * docs: update endpoints.md to document new ApiResponse object. * YS-113 - Updating endpoints to return ApiResponse on 404 statuses and model validations. * refactor: updated UI logic for login and password reset (#48) * refactor: updated UI logic for login and password reset to work with ApiResponse object * refactor: updated UI logic for login and password reset to work with ApiResponse object * fix: ensured only jwt token is being stored * feat: Added student registration and redirection. (#45) * YS-58, YS-59: Added student registration and redirection. * feat: Added student registration and redirection. * YS-114 refactor: updating school object to store ID as primary key. * feat: added endpoints for job applications (#47) * Added endpoints for job postings * postings now properly give user info * Added job application endpoints * refactored to api response --------- Co-authored-by: Cosmo48 <[email protected]> * YS-115 refactor: updating Event object to contain SchoolId. * YS-116 refactor: updated event creation endpoint to include school ID. * YS-79 feat: created endpoint to retrieve events. * refactor/docs: fixed typos and updated details for events endpoints; also updated endpoints.md * refactor: updating Job controller to return ApiResponse on ModelValidation fail. * YS-117 refactor: included userID claim in JWT for both employers and students. * Feat: added UI and UI logic for creating/viewing/deleting events as an Admin (#58) * Feat: added UI for events and create event pages * Feat: added UI for events and create event pages * YS-77: added UI and UI logic for creating/viewing/deleting events * YS-77: added back button, and uniform UI design for admin pages * Feat: added UI for events and create event pages * YS-77: added UI and UI logic for creating/viewing/deleting events * YS-77: added back button, and uniform UI design for admin pages * YS-77: fixed UI issues and ensured proper userId is used for requests * feat: Frontend UI to display Job Postings on Student Dashboard. (#52) * Updating Company table to include ID and user table to include Affiliation ID. * YS-118 refactor: Updated registration DTO, added affiliation ID to JWT. * feat: Front-end UI to display events on student dashboard. (#62) * docs: add sprint1 marks * YS-125 feat: added endpoint to count filtered events. * YS-121 feat: added endpoint to retrieve a list of all schools. * YS-123 feat: add endpoint to retrieve list of all companies. * YS-122 feat: added call to API to front-end to populate dropdown tab for schools during student registration. * YS-124 feat: added call to API in employer registration to populate company drop down list. * feat: Front-end UI to display Job Postings on Job Postings page (#69) * feat: Front-end UI to display events on student dashboard. * Updating Company table to include ID and user table to include Affiliation ID. * YS-118 refactor: Updated registration DTO, added affiliation ID to JWT. * feat: Front-End UI to display Job Postings on Job Postings page --------- Co-authored-by: Jason <[email protected]> * YS-126 bug: fixed registration. * fix: Next and Previous buttons now work on Job Posting page. * feat: added UI logic to view events from student events page (#59) * feat: added UI logic to view events from student events page * feat: Frontend UI to display Job Postings on Student Dashboard. (#52) * Updating Company table to include ID and user table to include Affiliation ID. * YS-118 refactor: Updated registration DTO, added affiliation ID to JWT. * feat: Front-end UI to display events on student dashboard. (#62) * docs: add sprint1 marks * YS-125 feat: added endpoint to count filtered events. * YS-121 feat: added endpoint to retrieve a list of all schools. * YS-123 feat: add endpoint to retrieve list of all companies. * YS-122 feat: added call to API to front-end to populate dropdown tab for schools during student registration. * YS-124 feat: added call to API in employer registration to populate company drop down list. * feat: Front-end UI to display Job Postings on Job Postings page (#69) * feat: Front-end UI to display events on student dashboard. * Updating Company table to include ID and user table to include Affiliation ID. * YS-118 refactor: Updated registration DTO, added affiliation ID to JWT. * feat: Front-End UI to display Job Postings on Job Postings page --------- Co-authored-by: Jason <[email protected]> * YS-126 bug: fixed registration. * fix: Next and Previous buttons now work on Job Posting page. * feat: added UI logic to view events from student events page * fix: Events now load depending on the school the student is associated with --------- Co-authored-by: Ethan Zhang <[email protected]> Co-authored-by: Jason <[email protected]> Co-authored-by: Jason Su <[email protected]> Co-authored-by: Navinn Ravindaran <[email protected]> Co-authored-by: Ethan Zhang <[email protected]> * feat: Paginated the events page for students. * bug: fixed a schema not loaded on Swagger. * YS-107 refactor: updated check company exists endpoint to return ApiResponse. * YS-108 refactor: updated create company endpoint to return ApiResponse. * YS-105 refactor: updated register employer endpoint to return ApiResponse. * YS-130 feat: added front-end validation on all current forms. * Deliverables (#76) * docs: Added documentation for jobs * docs: added PB.md * docs: updated formatting for PB.md * docs: added schedule.pdf * docs: added burndown.pdf * docs: updated api documentation for all APIs. * feat: added sprint velocity comparison between sprint 1 and sprint 2 * Added iteration plan and review deliverables. --------- Co-authored-by: Cosmo48 <[email protected]> Co-authored-by: Jason8908 <[email protected]> Co-authored-by: Junlin Qu <[email protected]> --------- Co-authored-by: Jason <[email protected]> Co-authored-by: YungCos <[email protected]> Co-authored-by: Jun <[email protected]> Co-authored-by: Jason Su <[email protected]> Co-authored-by: Cosmo48 <[email protected]> Co-authored-by: Anna Chester <[email protected]> Co-authored-by: Navinn Ravindaran <[email protected]>
* feat: added student profile (#79) * YS-128 bug: get job posting endpoint now also displays posting ID. * fix: job posting endpoint now allows search by employerid (#80) * YS-131 feat: added endpoint to get user by ID, updated front-end to store user object in cookies as JSON string, and updated student dashboard to display correct school name. * ci: add course table (#84) * fix: schools are now related to courses (#87) * YS-132 feat: added endpoint for admin registration. * fix: Registration redirects twice. (#86) * feat: endpoint to add courses (#89) * feat: addded backend for student profile (#83) * YS-138 feat: added endpoint to retrieve paginated filtered list of courses. * YS-177 feat: added endpoint to remove course from school. * YS-142 feat: added Schedule and Year tables to the database. * refactor: changed some fields to removed required. * fix: Registration redirects twice. (#90) * fix: Registration redirects twice. * fix: Employers are now able to login. * YS-144 feat: added endpoint to retrieve student schedule. * YS-144 bug: fixed student ID not returning in the correct field. * YS-178 feat: added endpoint to create a schedule for a student. * YS-178 feat: added endpoint to add/remove courses from a student's schedule. * ci: added script to populate course data to db (#93) * docs: copied api-documentation.md and PB.md to docs/sprint3 folder. * YS-146 feat: created course planning page for students and populated the UI with data. * feat: added/fixed endpoints for cover letters and experiences (#100) * fix: Added pagination to Admin dedicated events page. (#102) * YS-182 feat: added endpoint to retrieve number of filtered courses. * feat: Front-end to retrieve courses for admins in dedicated page. (#104) * Feat: added UI and UI logic to create/delete courses as admin (#105) * YS-139: added UI and UI logic to create courses * YS-139: added UI and UI logic to create courses * YS-139: added UI and UI logic to create courses * YS-139: added UI logic to delete courses * YS-146 feat: added front-end UI to remove courses from schedule. * YS-94 Feat: added UI and UI logic for student profile (#95) * YS-94: added UI and UI logic to create student profiles * YS-94 fix: added back button in create profile * YS-146 feat: added toaster package and animations for schedule page. * YS-146 bugfix: fixed module conflicts. * YS-183 bugfix: Removed employer validation from GET postings endpoint and added to POST postings endpoint. * feat: added info to job application creation/retrieval (#101) * Ys-83 rebased to sprint3 (#99) * fix: added missing getUserById function * feat: added button icons * feat: Added create/delete job postings as an employer * fix: querying now works with employer id * Feat: Added UI and UI logic to view student schedule on dashboard (#107) * YS-145: added UI and UI logic to display student schedule on dashboard * YS-145: added view all courses button to dashboard schedule * fix: fixed logic error for displaying schedules for grade 12+ * YS-145: added text to show if student has no current courses * Fix: now shows next year courses on dashboard (#109) * YS-145: added UI and UI logic to display student schedule on dashboard * YS-145: added view all courses button to dashboard schedule * fix: fixed logic error for displaying schedules for grade 12+ * YS-145: added text to show if student has no current courses * YS-145: fixed showing next courses * fix: Events do not display on the student dashboard. (#110) * YS-185 fix: create cover letter returns the full cover letter object (#111) * fix: create cover letter returns the full cover letter object * fix: updated the documentation to new return type * YS-25 backup: added script to generate SQL database. * YS-89: added UI and UI logic to see applicants for jop postings (#112) * Ys 87 sprint3 (#113) * YS-126 feat: added landing page and related logic. * YS-136 fix: removes relevant cookies if session is invalid. * feat: Added ability to log out. (#116) * feat: Added ability to log out. * Fixed timing issues with logging out. * feat: Added course display on Admin dashboard. (#117) * Added planning and review documents. * docs: added all sprint deliverables. --------- Co-authored-by: YungCos <[email protected]> Co-authored-by: Ethan Zhang <[email protected]> Co-authored-by: Anna Chester <[email protected]> Co-authored-by: Jun <[email protected]> Co-authored-by: Ethan Zhang <[email protected]>
* YS-164 feat: added Tag object into database. * feat: added university tables and data * YS-190 bugfix: landing page carousel slides now have same height. * YS-196 feat: added visual indicators on login page. * YS-197 feat: added UI notifications for password reset. * YS-194 ui: changed font for fornt-end UI along with small enhancements. * YS-195 ui: added UI inputs on creating job posting for employers. * YS-189 bug/feat: added soft deletion for cover letter. * YS-198 ui: added front-end ui indicators for creating events for admins. * Feat: added UI and UI logic for students to add courses with and without prereqs (#125) * YS-200: added UI and UI logic to add courses with and without prereqs * YS-200: ensured prereqs must be taken in before or concurrently * YS-199 feat: added front-end validation for admin create courses. * feat: added endpoint to retrive uni info (#130) * Creation of student toolkit page and layout for post secondary program search. * feat: added course reccomendations (#132) * YS-187: enhanced UI of navbar (#134) * Ys 134 202 (#131) * fix: added search functionality * feat: added search functionality into adding courses * feat: Added "none" for no prereqs and "or" in between prereqs * YS-150 feat: added front-end to search post secondary programs. * Removed alerts and logs. (#136) * YS-166 & YS-167: added course suggestions to add course page (#137) * (YS-192) feat: Added placeholder for no events or jobs on student dashboard. (#139) * Added placeholder for no events or jobs on student dashboard. * Fixed height for event and job preview. * YS-160 feat: added UI that displays cover letter on toolkit page. * Added launch profile * Sprint IV Deliverables (#141) * Added some sprint 4 delierables. * Added some sprint 4 delierables. * docs: Adding system design document * Added sprint review and iteration plan deliverables. --------- Co-authored-by: Jason8908 <[email protected]> Co-authored-by: Jason Su <[email protected]> --------- Co-authored-by: Jason <[email protected]> Co-authored-by: Cosmo48 <[email protected]> Co-authored-by: Jason Su <[email protected]> Co-authored-by: Anna Chester <[email protected]> Co-authored-by: YungCos <[email protected]> Co-authored-by: Jun <[email protected]>
* build: increased memory limit for Angular build. * refactor: changed front-end to get API base URL from settings file. * Added UI for cover letter creation. * Added functionality for cover letter creation. * Clearing cover letter creation form info when closed. * Added numerous features and bugfixes. (#144) --------- Co-authored-by: Jason8908 <[email protected]> Co-authored-by: Jason Su <[email protected]>
* Enhancements to the profile creation. * Final Touches (#147) * Added enhancements to post-secondary program search. * Corrected size of post-secondary planning buttons. --------- Co-authored-by: Jason8908 <[email protected]> --------- Co-authored-by: Jason8908 <[email protected]> Co-authored-by: Jason Su <[email protected]>
Great work everyone! 💪🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
mainsince the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @YungCos @xzyio @Jason8908 @TheZhangedMan @CodeMakesMeSmile