Skip to content

Commit

Permalink
HBVEC emulator improvement (#408)
Browse files Browse the repository at this point in the history
<!-- Please ensure the PR fulfills the following requirements! -->
<!-- If this is your first PR, make sure to add your details to the
AUTHORS.rst! -->
### Pull Request Checklist:
- [ ] This PR addresses an already opened issue (for bug fixes /
features)
  - This PR fixes #xyz
- [ ] (If applicable) Documentation has been added / updated (for bug
fixes / features).
- [ ] (If applicable) Tests have been added.
- [X] CHANGELOG.rst has been updated (with summary of main changes).
- [X] Link to issue (:issue:`number`) and pull request (:pull:`number`)
has been added.

### What kind of change does this PR introduce?

Added an alias for rain snow fraction to match other emulators.

### Does this PR introduce a breaking change?

This minor change should not lead to any breaking changes and it should
be covered by emulator tests already included in the repo.

### Other information:
  • Loading branch information
lou-a authored Oct 10, 2024
2 parents 86d6306 + 61310e3 commit 5a21e70
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Internal changes
* Many `numpydoc`-style docstrings have been adjusted for consistency.
* Added `setuptools` to the `gis` build recipe to ensure that the `gdal` bindings are built successfully. (PR #400)
* Modified the sub-basin and channel profile extraction functions to correctly set the river length to zero and set default values for reach attributes in sub-basins with no channel routing (i.e., sub-basins with lakes or headwater basins). (issue #354, PR #401)
* Improved the HBV-EC emulator by adding parameter information (name, definition, and Raven default values) and fixed the variable name for the adiabatic temperature lapse rate. (PR #404)
* Improved the HBV-EC emulator by adding parameter information (name, definition, and Raven default values), fixed the variable name for the adiabatic temperature lapse rate, and added an alias for rain snow fraction to match other emulators. (PR #404 and #408)

v0.15.0 (2024-06-20)
--------------------
Expand Down
4 changes: 3 additions & 1 deletion src/ravenpy/config/emulators/hbvec.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ class HBVEC(Config):
lw_radiation_method: o.LWRadiationMethod = Field(
"LW_RAD_DEFAULT", alias="LWRadiationMethod"
)
rain_snow_fraction: o.RainSnowFraction = Field("RAINSNOW_HBV")
rain_snow_fraction: o.RainSnowFraction = Field(
"RAINSNOW_HBV", alias="RainSnowFraction"
)
potential_melt_method: o.PotentialMeltMethod = Field(
"POTMELT_HBV", alias="PotentialMeltMethod"
)
Expand Down

0 comments on commit 5a21e70

Please sign in to comment.