Update notebooks to work with changes to dask chunking #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me do the merge of this PR when it will be ready. This PR can only be merged at the same time the new Jupyter env is live. |
|
@tlvu For this PR, feel free to ignore the failing tests and use your admin rights to bypass the protections. The code changes here are ready and shouldn't break things in production, from what I can tell. If I can get the other PRs here approved, tests should pass without problems. |
Zeitsperre
force-pushed
the
fix-pjei-12
branch
from
cb46479
to
b4764bb
Compare
Zeitsperre
force-pushed
the
fix-pjei-12
branch
from
b4764bb
to
fac4e28
Compare
huard
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 1/2 of https://github.com/Ouranosinc/pavics-jupyter-env-issues/issues/12
FYI @tlvu
Changes
daskis properly performed