Changing the RNG in kmeans.h to platform agnostic. #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changes the type of the values to double.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Looks like the clang-tidy warning is resolved with this PR. Merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes the type of the values to double to match the array type.
Implemented with mt19937_64 from std::random seeded with std::random_device which uses hardware entropy where available.
Changes the range of the values to be the whole range of double. I don't know if the limit to data.size() was intentional or not.
Changing it back just needs changing the values passed to std::uniform_real_distribution.
If for whatever reason this rng is too slow (shouldn't be) the PRNG would need to be changed to a different algorithm.
Can't get the indentation to be fixed, so sadly the whole file changed.