Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ban updates2.0 #2293

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Ban updates2.0 #2293

wants to merge 12 commits into from

Conversation

TitanVJ
Copy link
Contributor

@TitanVJ TitanVJ commented Feb 2, 2025

Description

  • ban() now uses guild.ban() to facilitate clearing messages because its instant and the slowness of the previous method was not liked. also sometimes the clearing of messages just wouldn't work
  • intercept updated to use halting problem to capture audit log data, will reduce the number of failures if discord takes longer to generate the audit entry
  • removed all intermediate message, prevents clutter from mod report channel
  • all responses are sent to mod channel instead of responding to the interaction
  • updated default ban reason
  • embed utility was dropped for most commands in Ban, was unnecessary for most of the embeds since they're deterministic in size
  • no more getting discrimintors for users since they were phased out last year, now pulling from user.name()

@TitanVJ TitanVJ requested a review from a team as a code owner February 2, 2025 19:56
@TitanVJ
Copy link
Contributor Author

TitanVJ commented Feb 2, 2025

@modernNeo

Seems my first branch has some commits from master that've since been removed. So I made this fresh branch and cherry picked my commits over.

Copy link
Member

@modernNeo modernNeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add the embed helper back. the checks against the text sizes was just 1 thing it does. hint take a look at line of code under 180 on embed.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants