Add induction command

[sapphyree]

As per @rainestormee's suggestion, adds an /induct command to automatically give a user the Guest role whilst sending a message in general to highlight the fact they've joined and to draw their attention to the new channels.

[MattyTheHacker]

Personally I think it's better to have this done by automatically checking reacts but this works too

[sapphyree]

Personally I think it's better to have this done by automatically checking reacts but this works too

The problem with automatically checking reacts is that you're spending processing time constantly checking all of the messages in introductions. In addition, you're checking every user that reacts (because there's no way to just filter) and that takes up a lot of time checking the cache (or, in some cases, performaing an async fetch and re-checking the cache). This way is more annoying, yes, but it's easier to not have to worry about checking every message in the channel.

[MattyTheHacker]

Very good points, can't argue with that

[LMBishop]

The only concern I have is that the welcome message could get spammy, especially during welcome week.

Also, not really that important, but something to consider is a logging library for less 'fragile?' (for lack of a better term) logs.

[LMBishop]

Oooo I've just had an idea, I know you've already implemented it like this, buuut I've seen an 'Apps' thing when you right click messages on Discord and I think it would be pretty cool to have one of those also trigger this

[MattyTheHacker]

Oooo I've just had an idea, I know you've already implemented it like this, buuut I've seen an 'Apps' thing when you right click messages on Discord and I think it would be pretty cool to have one of those also trigger this

Seconded, that would be pretty cool

[MattyTheHacker]

The only concern I have is that the welcome message could get spammy, especially during welcome week.

Could potentially add an option to the command where the user can specify whether they want it to send a message in general or not? Partially because I think it should DM them as well in all cases also to remind them to change their nickname and to grab roles etc...

https://github.com/CSSUoB/TeX-Bot/issues/37

#8

[sapphyree]

The only concern I have is that the welcome message could get spammy, especially during welcome week.

Could potentially add an option to the command where the user can specify whether they want it to send a message in general or not? Partially because I think it should DM them as well in all cases also to remind them to change their nickname and to grab roles etc...

https://github.com/CSSUoB/TeX-Bot/issues/37

#8

The DMing functionality is OoS for this PR and this command right now, though I was thinking of adding a silent Boolean option yes.

[JTWWilson]

Re: @LMBishop's concerns about spamming, I think the best approach would be to enable the functionality and see how annoying it is. Anything else is conjecture and I don't think that enabling it for a short amount of time is much of an issue.

[sapphyree]

Re: @LMBishop's suggestion with the logging library - I agree, in the future I'd like to move to a better solution to logging events, but for right now I think it's probably fine? Feel free to open an issue and/or implement it yourself <3

[LMBishop]

Oh yeah of course, this PR is fine as is (aside from the typos). I'll raise the other issues separately when I get the chance