Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the archive command #303

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Improve the archive command #303

wants to merge 13 commits into from

Conversation

MattyTheHacker
Copy link
Member

No description provided.

@MattyTheHacker MattyTheHacker self-assigned this Aug 6, 2024
@MattyTheHacker MattyTheHacker added enhancement New feature or request refactor Improvements to the codebase that do not directly affect users labels Aug 6, 2024
Copy link
Member

@CarrotManMatt CarrotManMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you provide more information about why all of the fine-grained permissions have been removed? The existing functionality ensures that the channel/category retains the correct committee permissions after archiving.

cogs/archive.py Show resolved Hide resolved
cogs/archive.py Show resolved Hide resolved
@MattyTheHacker
Copy link
Member Author

The issue around users being able to see names of channels that are committee only isn't an issue, because the stats command does the same as does statbot

@MattyTheHacker
Copy link
Member Author

Also not sure what you mean about the permissions - this method syncs permissions to the archive channel which handles all the permissions automatically for all the channels in that category, doing it one by one in this cog is unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactor Improvements to the codebase that do not directly affect users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants