Add new table names to the make_member cog #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Normally I'd say no to the just adding to the list of the table IDs but I think its okay as this will get patched out anyway when my MSL PR get's merged - though ofc that may be some time so up to Matt |
MattyTheHacker
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Nothing wrong with adding new table IDs and leaving them in permenantly. The only possible issue is if one of those IDs eventually gets used for a table representing something like banned/non members. If TeX-Bot attempts to look for table IDs that don't exist, they'll just be skipped.
CarrotManMatt
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've kept the old ones in because I already have trust issues, you think I'm gonna trust the Guild to not potentially change them back?