Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding GitHub link to the about page #158

Merged
merged 4 commits into from
Aug 21, 2021
Merged

Adding GitHub link to the about page #158

merged 4 commits into from
Aug 21, 2021

Conversation

MattyTheHacker
Copy link
Member

Adding a link to this GitHub repo on the about page as per #142.

Add GitHub link to redirects
Add GitHub to the CSS for the about page
Added GitHub link to the about page
css/about.scss Outdated

.github {
h4, i {
color: #FFFFFF;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to comment about consistent casing for hex, but it seems like it's inconsistent elsewhere.
We should probably look into having some consistency and decide to use uppercase or lowercase.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, I'm planning a tidy up of SCSS and colours in future so this can be done in that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for now could be fine, then eventually resolved in #159 or if you have another issue / milestone for that?

@AlexJBanks
Copy link
Member

Ty @MattyTheHacker, I'll review in morning

@rainestormee
Copy link
Member

rainestormee commented Aug 21, 2021

image
This looks very bright to me, would it be better to have it in black so it's more readable against a white background?

@MattyTheHacker
Copy link
Member Author

MattyTheHacker commented Aug 21, 2021

image
This looks very bright to me, would it be better to have it in black so it's more readable against a white background?

Damn, that's my bad. Both the logo and the text was supposed to be black in the first place!
EDIT: Just updated the text but not actually sure how to get the icon black so if anyone else does then please feel free!

@rainestormee
Copy link
Member

rainestormee commented Aug 21, 2021

image
This looks very bright to me, would it be better to have it in black so it's more readable against a white background?

Damn, that's my bad. Both the logo and the text was supposed to be black in the first place!
EDIT: Just updated the text but not actually sure how to get the icon black so if anyone else does then please feel free!

image
Well looks like it's now black -- would it be better to do all of these changes in one commit as opposed to a few commits and a change? squash

@rainestormee rainestormee self-requested a review August 21, 2021 01:09
Copy link
Member

@rainestormee rainestormee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, probably have @AlexJBanks double-check though just in case 👀

The issue's wording is a bit confusing, it may mean link to https://github.com/CSSUoB as opposed to this exact repo however?

Copy link
Member

@AlexJBanks AlexJBanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good, Thanks @MattyTheHacker

@AlexJBanks AlexJBanks merged commit 25888fa into CSSUoB:master Aug 21, 2021
@AlexJBanks AlexJBanks linked an issue Aug 21, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add link to GitHub repo from website
3 participants