-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GitHub link to the about page #158
Conversation
Add GitHub link to redirects
Add GitHub to the CSS for the about page
Added GitHub link to the about page
css/about.scss
Outdated
|
||
.github { | ||
h4, i { | ||
color: #FFFFFF; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to comment about consistent casing for hex, but it seems like it's inconsistent elsewhere.
We should probably look into having some consistency and decide to use uppercase or lowercase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better, I'm planning a tidy up of SCSS and colours in future so this can be done in that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So for now could be fine, then eventually resolved in #159 or if you have another issue / milestone for that?
Ty @MattyTheHacker, I'll review in morning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, probably have @AlexJBanks double-check though just in case 👀
The issue's wording is a bit confusing, it may mean link to https://github.com/CSSUoB as opposed to this exact repo however?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code is good, Thanks @MattyTheHacker
Adding a link to this GitHub repo on the about page as per #142.