Use larger images for committee profiles #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AKP <[email protected]>
codemicro
requested review from
JTWWilson,
LMBishop,
MattyTheHacker and
rainestormee
as code owners
LMBishop
reviewed
Jun 25, 2023
MattyTheHacker
approved these changes
Jun 25, 2023
Thatsmusic99
approved these changes
Jun 25, 2023
There was a problem hiding this comment.
LGTM, did think the current committee photos were quite low in resolution. These look a lot better :D
(RIP Ellie's photo though, seems to be botched on the update committee branch too though, I presume that just needs fixing there?) seems fine in the main deployment, so it shouldn't be a big deal.
|
All the pics look fine for me on the other PR? Can't check again now for this one and there isn't a deploy preview but maybe check you're up to date? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix to #428 that increases the resolution of the images outputted by the minify script to make them look better on the site. Rationale is explained in this comment.
Refs #417