Feature/selenium tests for schedule editor #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some tests using selenium to exercise some of our cutom ajvascript code (our custom datetime widget & the schedule editor)
Closes: #159
Some notes:
I've marked as expected failures some cases where the schedule editor behavior isn't correct (See #689 and #158 ).
Firefox and drag and drop with selenium seems flakey at the moment - see failures at https://wpt.fyi/results/webdriver/tests/bidi/input/perform_actions/pointer_mouse_drag.py?label=experimental&label=master&aligned and related issues like https://bugzilla.mozilla.org/show_bug.cgi?id=1515879 - hopefully this wlll get better
We will need to add more support for customising the webdriver config, to support things like using browsers in snaps on ubuntu and so forth.
I haven't looked at what's required to run these via github actions yet.