Refactor into main workflow and reusable workflow for the tests #703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The duplicated matrix for sqlite and postgres is a pain to maintain, but github doesn't yaml anchors and aliases, which would be the usual way to solve this Gitub does support reusable actions, though, which does allow us to unify the two matrixes at the cost of splitting the workflow into two files, which is not still not great, but is better.
|
It's possible to remove he duplication of logic in run_tests.yml by adding another reusable file to handle the common bits (github allows up to 4 levels of this), but I'm not yet annoyed enough by it to go that far down this rabbit hole. |
hodgestar
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The duplicated matrix for sqlite and postgres is a pain to maintain, but github doesn't yaml anchors and aliases, which would be the usual way to solve this
Gitub does support reusable actions, though, which does allow us to unify the two matrixes at the cost of splitting the workflow into two files, which is not still not great, but is better.