talks: configure maximum number of talk authors to list explicitly #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have been using wafer instances for single-track events, where there is plenty of space in the schedule to just list all authors. This will let me configure my instances to list a higher number than 2.
terceiro
force-pushed
the
config-et-al
branch
from
a56da00 to
02d6076
Compare
drnlm
reviewed
Nov 27, 2024
| @@ -283,7 +283,7 @@ def get_authors_display_name(self): | |||
| key=lambda author: u'' if author == self.corresponding_author | |||
| else author.userprofile.display_name()) | |||
| names = [author.userprofile.display_name() for author in authors] | |||
| if len(names) <= 2: | |||
| if len(names) <= settings.WAFER_SCHEDULE_MAX_AUTHORS: | |||
| return u' & '.join(names) | |||
There was a problem hiding this comment.
As a future improvement, it would be nice to tweak the formatting here for more than two names so it returns
Author A, Author B, Author C & Author D
instead of
Author A & Author B & Author C & Author D
drnlm
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been using wafer instances for single-track events, where there is plenty of space in the schedule to just list all authors. This will let me configure my instances to list a higher number than 2.