Support custom encode/decode of exponent+IE #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead follow what the sail model does and invert the exponent and IE
values when reading them as part of the decode. This will also be useful
for supporting the RISC-V standard encoding which also avoids the XOR
on load and instead deals with the inversion during decode.
Introduce new _CC_N({ENCODE,EXTRACT}_{IE,EXPONENT}) macros to deal with
the differences in formats instead of reading the raw field values.
This also includes various Morello test changes since the input PESBT
values now need to be passed without the previous mask applied.
arichardson
force-pushed
the
morello-avoid-xor
branch
from
e66b1e9 to
9d5a656
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of performing a "fake" xor part way through the decode.
This will also be helpful to support the https://riscv.github.io/riscv-cheri/ encoding.