Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These interact quite poorly with MRS with revocation enabled, which implements realloc() by always creating a new allocation. Even a modification to return the original pointer if its bounds satisfy the request doesn't help much there.
Apply a simple bandaid: grow the allocation exponentially. This has no major downside except when virtual address space is scarce, and that's something we don't typically worry about. There doesn't appear to be any explicit justification for growing buffers so conservatively.
This yields a significant reduction in the amount of time needed to build a cscope database (cscope invokes sort(1) under the hood).