Backport upstream bug fixes for control register handling #2318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic in update_special_reg_field was reversed. Fix by swapping the order of the arguments. PR: 282505 Fixes: f1fb1d5 ("arm64: Support more ID register field types") Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D47437 (cherry picked from commit ce284dded5d5db6b1bceda309dccba616f485ade)
When comparing two ID registers to create a common userspace view we have an option where we set an exact value only if the two are different. This is only used in one field in the cache type register that is accessible by userspace without being trapped by the kernel. In preparation for trapping access to this register to handle it in the kernel in some situations fix the 'if different' check. Sponsored by: Arm Ltd Differential Revision: https://reviews.freebsd.org/D47811 (cherry picked from commit 14006c96214a772ba2e2f07bb4301657d8c2055a)
bsdjhb
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed in order to boot bhyve guests on CheriBSD.